🐛 Fix LSP printers devnull fd kept open

Ackee-Blockchain · May 22, 2024 · 696f467 · 696f467
1 parent 411351b
commit 696f467
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/wake/lsp/lsp_compiler.py b/wake/lsp/lsp_compiler.py
@@ -1161,22 +1161,23 @@ async def __run_printers(self) -> None:
             logging_buffer = []
             logging_handler = LspLoggingHandler(logging_buffer)
 
-            console = Console(file=open(os.devnull, "w"))
-
-            _, printer_exceptions = run_printers(
-                all_printers,
-                self.last_build,
-                self.last_build_info,
-                self.__last_graph,
-                self.__config,
-                console,
-                None,
-                self.__printers_lsp_provider,
-                verify_paths=False,
-                capture_exceptions=True,
-                logging_handler=logging_handler,
-                extra={"lsp": True},
-            )
+            with open(os.devnull, "w") as devnull:
+                console = Console(file=devnull)
+
+                _, printer_exceptions = run_printers(
+                    all_printers,
+                    self.last_build,
+                    self.last_build_info,
+                    self.__last_graph,
+                    self.__config,
+                    console,
+                    None,
+                    self.__printers_lsp_provider,
+                    verify_paths=False,
+                    capture_exceptions=True,
+                    logging_handler=logging_handler,
+                    extra={"lsp": True},
+                )
             exceptions = {name: repr(e) for name, e in printer_exceptions.items()}
 
             for log, log_type in logging_buffer: