Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove *.orig files #37

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Dec 9, 2024

Important

This pull request adds dialog and notification plugins, enhances configuration management, implements a file watcher, and improves module crash handling in the Tauri application.

  • Behavior:
    • Added tauri_plugin_dialog and tauri_plugin_notification plugins in lib.rs.
    • Implemented single-instance lock mechanism in lib.rs.
    • Introduced SpecificFileWatcher in lib.rs to monitor file creation events.
    • Enhanced module crash handling in manager.rs to restart modules and notify users.
  • Configuration:
    • Added UserConfig struct in lib.rs for managing user settings like autolaunch and port.
    • Config file path management and default configuration setup in lib.rs.
  • Misc:
    • Updated tray menu management in manager.rs to reflect module states.
    • Added new permissions and capabilities in JSON schema files.

This description was created by Ellipsis for b012c7b. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b012c7b in 3 minutes and 21 seconds

More details
  • Looked at 3987 lines of code in 11 files
  • Skipped 1 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. src-tauri/src/lib.rs:35
  • Draft comment:
    Using unwrap() can cause the program to panic if the value is None. Consider using expect() with a meaningful error message or handling the error gracefully.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. src-tauri/src/lib.rs:41
  • Draft comment:
    Using unwrap() can cause the program to panic if the value is None. Consider using expect() with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap() is used.
  • Reason this comment was not posted:
    Marked as duplicate.
3. src-tauri/src/lib.rs:45
  • Draft comment:
    Using unwrap() can cause the program to panic if the value is None. Consider using expect() with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap() is used.
  • Reason this comment was not posted:
    Marked as duplicate.
4. src-tauri/src/lib.rs:49
  • Draft comment:
    Using unwrap() can cause the program to panic if the value is None. Consider using expect() with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap() is used.
  • Reason this comment was not posted:
    Marked as duplicate.
5. src-tauri/src/lib.rs:146
  • Draft comment:
    Using unwrap() can cause the program to panic if the value is None. Consider using expect() with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap() is used.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_fxl0YPYWduSlrvm6


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo 0xbrayo merged commit 9d8fc6e into ActivityWatch:master Dec 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant