Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use checkmarks for module running state #45

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Dec 16, 2024

Important

Use CheckMenuItem for module running state in tray menu and remove certain modules from path in manager.rs.

  • Behavior:
    • Use CheckMenuItem instead of MenuItem in update_tray_menu() in manager.rs to show module running state with checkmarks.
  • Modules:
    • Remove aw-client and aw-cli from get_modules_in_path() in manager.rs for both Unix and Windows.

This description was created by Ellipsis for a05eac2. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a05eac2 in 24 seconds

More details
  • Looked at 56 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src-tauri/src/manager.rs:335
  • Draft comment:
    Duplicate removal of "aw-tauri", "aw-client", and "aw-cli". This is redundant and should be cleaned up. Applies to both Unix and Windows versions of get_modules_in_path.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_Cp8kd2poOeAuiiTq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo 0xbrayo mentioned this pull request Dec 16, 2024
2 tasks
@0xbrayo 0xbrayo merged commit a886408 into ActivityWatch:master Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant