Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restart modules limit #50

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Dec 21, 2024

#48


Important

Adds a restart limit of 3 attempts for modules in ManagerState, with error dialogs when limit is reached.

  • Behavior:
    • Adds modules_restart_count to ManagerState to track module restarts.
    • Limits module restarts to 3 attempts in handle() function.
    • Displays error dialog when restart limit is reached.
  • Functions:
    • Updates handle() to increment restart count and check against limit.
    • Uses get_app_handle() to show dialogs for module crash and restart limit reached.

This description was created by Ellipsis for a1256a4. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a1256a4 in 16 seconds

More details
  • Looked at 61 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src-tauri/src/manager.rs:227
  • Draft comment:
    Consider resetting the modules_restart_count for a module after it has started successfully. This will ensure that the restart limit is only applied to consecutive failures.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_MmtpPiPEv5BTFvy4


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo 0xbrayo merged commit 458e2b7 into ActivityWatch:master Dec 21, 2024
5 checks passed
@0xbrayo 0xbrayo mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant