feat: update the discovery_path for macos + misc refactors

[0xbrayo]

Important

Update macOS discovery path and refactor module management in lib.rs and manager.rs.

• Behavior:
  • Update discovery_path for macOS in Defaults::default() in lib.rs to /Applications/ActivityWatch.app/Contents/MacOS.
  • Optimize autostart logic in run() in lib.rs by checking state before enabling/disabling.
• Refactors:
  • Rename get_modules_in_path() to discover_modules() in manager.rs and lib.rs.
  • Rename modules_in_path to modules_discovered in ManagerState in manager.rs.
  • Reorganize imports in manager.rs for clarity.
• Misc:
  • Add TODO comment in run() in lib.rs suggesting concurrent setup to improve startup time.

^{This description was created by for 4e992da. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 4e992da in 54 seconds

More details

• Looked at 164 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 9 drafted comments based on config settings.

1. src-tauri/src/lib.rs:212

• Draft comment:
  Using cfg!(target_os = "linux") ensures discoveryPath is only set on Linux. Ensure this meets your intent for macOS support since now it's handled separately below.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

2. src-tauri/src/lib.rs:333

• Draft comment:
  TODO comment notes potential concurrent setup improvements. Consider opening an issue or providing more context for a future refactor.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

3. src-tauri/src/lib.rs:358

• Draft comment:
  Typo in error message: 'autosart' should be 'autostart'.
• Reason this comment was not posted:
  Comment was on unchanged code.

4. src-tauri/src/lib.rs:212

• Draft comment:
  Using cfg!(target_os = "linux") means only Linux is handled; other Unix (e.g. BSD) will fall into the default branch. Confirm this is intended.
• Reason this comment was not posted:
  Comment did not seem useful.

5. src-tauri/src/lib.rs:219

• Draft comment:
  Hardcoding the macOS discovery path; ensure this path suits all deployment scenarios on macOS.
• Reason this comment was not posted:
  Comment did not seem useful.

6. src-tauri/src/lib.rs:354

• Draft comment:
  When disabling autostart, consider checking its state first (as done in the enable branch) and fix the typo 'autosart' to 'autostart'.
• Reason this comment was not posted:
  Marked as duplicate.

7. src-tauri/src/manager.rs:56

• Draft comment:
  Renaming 'modules_in_path' to 'modules_discovered' clarifies intent; ensure associated docs/tests reflect the change.
• Reason this comment was not posted:
  Comment did not seem useful.

8. src-tauri/src/manager.rs:347

• Draft comment:
  Renaming function from 'get_modules_in_path()' to 'discover_modules()' improves clarity; verify consistent usage across platforms.
• Reason this comment was not posted:
  Comment did not seem useful.

9. src-tauri/src/manager.rs:362

• Draft comment:
  Consider handling errors from directory reads explicitly instead of silently ignoring them when discovering modules.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_axEPs1NUcuW1Npas

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.