misc: mark remove placeholder webapp as done + renamed get_log_file -> get_log_filepath #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 904d553 in 1 minute and 41 seconds
More details
- Looked at
62lines of code in3files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. src-tauri/src/logging.rs:8
- Draft comment:
Potential bug: 'create_dir_all' is called on a file path. Use the parent directory instead, e.g., create_dir_all(&log_path.parent().unwrap()) to ensure the log directory exists. - Reason this comment was not posted:
Marked as duplicate.
2. README.md:67
- Draft comment:
Checklist updated: Marking 'Remove placeholder Vue app' as done. Looks good if feature is complete. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. src-tauri/src/lib.rs:460
- Draft comment:
Function name updated toget_log_filepathappears consistent with renaming in the logging module. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. src-tauri/src/logging.rs:7
- Draft comment:
Potential bug:get_log_filepathreturns the full log file path, butsetup_loggingcallscreate_dir_allon it and then appends the filename again. This may create an incorrect directory path (e.g. .../aw-tauri.log/aw-tauri.log). - Reason this comment was not posted:
Comment was on unchanged code.
5. src-tauri/src/logging.rs:17
- Draft comment:
Changed trace color from White to BrightBlue looks intentional. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_9wd1AvqDtFZoyVTJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
ErikBjare
reviewed
Feb 6, 2025
| @@ -51,7 +49,8 @@ pub fn setup_logging() -> Result<(), fern::InitError> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn get_log_file() -> PathBuf { | |||
| pub fn get_log_filepath() -> PathBuf { | |||
There was a problem hiding this comment.
Not to be nitty, but I think get_log_path would be the best name 😅 (no need to change though)
There was a problem hiding this comment.
Spent almost 5 mins debating it lol. Chose wrong😅. Will sneak the change in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Mark "Remove placeholder Vue app" as done in
README.mdand renameget_log_file()toget_log_filepath()in the codebase.README.md.get_log_file()toget_log_filepath()insrc-tauri/src/lib.rsandsrc-tauri/src/logging.rs.This description was created by
for 904d553. It will automatically update as commits are pushed.