Avoid intermediate JSON AST creation #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruediger
commented
Mar 29, 2021
| fn serve_ws( | ||
| &self, | ||
| ctx: Ctx, | ||
| raw_req: Value, | ||
| service_id: &str, | ||
| ) -> BoxStream<'static, Result<Value, ErrorKind>>; | ||
| ) -> BoxStream<'static, Result<Resp, ErrorKind>>; |
There was a problem hiding this comment.
return the Serializable instead of the AST
| .map(|resp_result| { | ||
| resp_result | ||
| .map(|resp| { | ||
| serde_json::to_value(&resp) |
| &self, | ||
| _ctx: (), | ||
| req: Self::Req, | ||
| ) -> BoxStream<'static, Result<Self::Resp, String>> { |
There was a problem hiding this comment.
looks like we need to box Self::Resp here but that fails with
the traitformats::_::serde::Serializecannot be made into an objectformats::::_serde::Serializecannot be made into an objectrustc(E0038)
which https://crates.io/crates/erased-serde might solve.
| let services = Arc::new(maplit::btreemap! {"test" => TestService::new().boxed()}); | ||
| let services = Arc::new(maplit::btreemap! { | ||
| "test" => TestService::new().boxed(), | ||
| "test2" => TestService2::new().boxed(), |
There was a problem hiding this comment.
this now fails as the return type of serve differs.
aruediger
changed the title
This was referenced May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.