Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/initial message params #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nafisto
Copy link

@nafisto nafisto commented Jun 15, 2016

The final two parameters for the setInitialMessage and setCapturingMessage methods aren't being taken because the argument index is wrong. (Looks like a copy-paste error.) This PR fixes the argument indexes so they are pulled correctly from the Cordova command.

@nafisto
Copy link
Author

nafisto commented Oct 31, 2016

@tbehera @DiegoArenaOlivera Any chance this can be fixed? I don't mind running my own fork but I'm guessing other users may be running into this.

@vgargacuant
Copy link
Contributor

@tbehera - I think this is already fixed?

@nafisto
Copy link
Author

nafisto commented Nov 2, 2016

As of now, master is still showing the argument indices that aren't correct:

NSNumber *durationnumber = [command.arguments objectAtIndex:7];
int duration = durationnumber.intValue;
NSNumber *orientationnumber = [command.arguments objectAtIndex:7];

NSNumber *durationnumber = [command.arguments objectAtIndex:7];
int duration = durationnumber.intValue;
NSNumber *orientationnumber = [command.arguments objectAtIndex:7];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants