Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore) - Optimisation - Used non indexed keys on map method #12

Merged
merged 1 commit into from
Mar 30, 2019

Conversation

anthonytranDev
Copy link
Collaborator

Dependency Changes
shortid

Reason for dependency - generates a non indexed & gives the key a hashed value; which is optimising for React

De-optimising index keys or reused strings were removed and replaced with either:

  • API Keys
  • shortid Keys - this fixes the issue of using label as key value - replaces this with a hashed value

Dependency Changes
shortid

Reason for dependency - generates a non indexed & gives the key a hashed value; which is optimising for React

De-optimising index keys or reused strings were removed and replaced with either:

- API Keys
- shortid Keys - this fixes the issue of using `label` as key value - replaces this with a hashed value
@Adam-Collier Adam-Collier merged commit ac6785e into Adam-Collier:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants