Full test coverage

Chai plugin buried for now

chai.js

@@ -0,0 +1,26 @@
+module.exports = function(chai, utils) {
+  var Assertion = chai.Assertion;
+  var flag = utils.flag;
+
+  function inRenderedOutput(query, msg) {
+    if (msg) flag(this, 'message', msg);
+    var renderer = flag(this, 'object');
+
+    var node = renderer.findNode(query);
+    this.assert(node,
+      'Expected to find #{exp} in #{act}',
+      'Expected not to find #{exp} in #{act}',
+      query, renderer
+    );
+  }
+
+  Assertion.addMethod('inRenderedOutput', inRenderedOutput);
+
+  chai.assert.inRenderedOutput = function(renderer, query, msg) {
+    new Assertion(renderer, msg).to.have.inRenderedOutput(query, msg);
+  };
+
+  chai.assert.notInRenderedOutput = function(renderer, query, msg) {
+    new Assertion(renderer, msg).to.not.have.inRenderedOutput(query, msg);
+  };
+};

skin-deep.js

@@ -14,10 +14,12 @@ function shallowRender(elementOrFunction, context) {
   shallowRenderer.render(element, context);
   ReactContext.current = {};
   return {
-    findNode: findNodeIn.bind(0, shallowRenderer),
+    findNode: function(query) {
+      return findNodeIn(shallowRenderer, query);
+    },
     textIn: function(query) {
       var node = findNodeIn(shallowRenderer, query);
-      return node && node.props && String(node.props.children);
+      return getTextFromNode(node);
     },
     text: function() {
       return getTextFromNode(shallowRenderer.getRenderOutput());
@@ -95,7 +97,7 @@ function getTextFromNode(node) {
   }
   // Iterables get combined with spaces
   if (typeof node.map === 'function') {
-    return node.map(getTextFromNode).join(' ');
+    return node.map(getTextFromNode).join(' ').replace(/\s+/, ' ');
   }
   // Non-dom components are a black box
   if (TestUtils.isElement(node) && typeof node.type !== 'string') {
@@ -110,30 +112,3 @@ function getTextFromNode(node) {
   // Otherwise, stop
   return '';
 }
-
-exports.chaiShallowRender = function(chai, utils) {
-  var Assertion = chai.Assertion;
-  var flag = utils.flag;
-
-  function inRenderedOutput(query, msg) {
-    if (msg) flag(this, 'message', msg);
-    var renderer = flag(this, 'object');
-
-    var node = renderer.findNode(query);
-    this.assert(node,
-      'Expected to find #{exp} in #{act}',
-      'Expected not to find #{exp} in #{act}',
-      query, React.renderToString(renderer.getRenderOutput())
-    );
-  }
-
-  Assertion.addMethod('inRenderedOutput', inRenderedOutput);
-
-  chai.assert.inRenderedOutput = function(renderer, query, msg) {
-    new Assertion(renderer, msg).to.have.inRenderedOutput(query, msg);
-  };
-
-  chai.assert.notInRenderedOutput = function(renderer, query, msg) {
-    new Assertion(renderer, msg).to.not.have.inRenderedOutput(query, msg);
-  };
-};

test/test.js

@@ -167,6 +167,14 @@ describe("skin-deep", function() {
         .to.have.property("value", "glenjamin");
     });
 
+    it("should no-op on field without change handler", function() {
+      var before = tree.findNode(".nickname");
+
+      tree.fillField(".nickname", "glenjamin");
+
+      expect(tree.findNode(".nickname")).to.eql(before);
+    });
+
     it.skip("should set value of uncontrolled text field", function() {
       // Can this be done?
     });
@@ -194,7 +202,7 @@ describe("skin-deep", function() {
       var tree = sd.shallowRender($('h1', { title: "blah" },
         "Heading!",
         $('div', { title: "blah" },
-          123,
+          123, $('hr'),
           'Some text.',
           'More text.',
           [ React.createElement(Widget, { key: 1 }),