[trello.com/c/0dgGzsPE]: timeouts for sending messages #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to add timeout to
HealthCheckWrapper
functions. As to me, adding timeout toAPICoreProtocol
makes no sense, because basic network timeout in Alamofire is much less - only 60 s. So the most actual waiting happens inside waiting for connection inHealthCheckWrapper
.Also, I added timeouts generating adamant-walled in CoinScript.rb.
As for now, there is the same timeout for message and message with files attachments. So
isFileTransfer
is how we decide whether is it simple message or message with files.For handling timeouts I've added generic function
deadline
in CommonKit. It supports actor isolation as well.Because not all services support timeouts, I've added new protocol
HealthCheckableTimeoutableError
and we add new function with timeout forHealthCheckWrapper
only whenError: HealthCheckableTimeoutableError