Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for slider bug in interactive viewers #76

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

cheesema
Copy link
Member

@cheesema cheesema commented Jul 11, 2024

Problem:

A change in the behaviour of our QT based slider dependencies have resulted in a bug due to float values being passed in where the underlying libraries now only support integers.

Solution:

Cast the inputs to integers before they reach the slider components.

Note: This is a patch fix, and could have some un-intended consequences.

However, the main objective is to get these working agian from a fresh install.

Testing:

Worked locally on Windows / WSL. But to be confirmed by Joel before merge.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.15%. Comparing base (191b674) to head (9220cee).

Files Patch % Lines
pyapr/utils/filegui.py 0.00% 8 Missing ⚠️
pyapr/viewer/compressInteractive.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   75.24%   75.15%   -0.10%     
==========================================
  Files          56       56              
  Lines        2460     2463       +3     
==========================================
  Hits         1851     1851              
- Misses        609      612       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants