fix sticky-polyfill causing crash on destroy (#1118)

* fix: add optional chaining to prevent a crash * test: write test for destroy behaviour
Addepar · Aug 1, 2024 · f2953a2 · f2953a2
1 parent 393d36f
commit f2953a2
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/addon/-private/sticky/table-sticky-polyfill.js b/addon/-private/sticky/table-sticky-polyfill.js
@@ -210,6 +210,6 @@ export function setupTableStickyPolyfill(element) {
 }
 
 export function teardownTableStickyPolyfill(element) {
-  TABLE_POLYFILL_MAP.get(element).destroy();
+  TABLE_POLYFILL_MAP.get(element)?.destroy();
   TABLE_POLYFILL_MAP.delete(element);
 }
diff --git a/tests/integration/components/basic-test.js b/tests/integration/components/basic-test.js
@@ -399,5 +399,32 @@ module('Integration | basic', function() {
       document.querySelector('#ember-testing-container').style.height = '600px';
       this.set('showComponent', false);
     });
+
+    test('Destroying table with footerRows after initial render does not trigger error', async function(assert) {
+      assert.expect(0);
+
+      this.set('columns', generateColumns(4));
+      this.set('rows', generateRows(10));
+
+      this.set('showComponent', true);
+
+      await render(hbs`
+        {{#if this.showComponent}}
+          <div id="container" style="height: 500px;">
+            <EmberTable as |t|>
+              <EmberThead @api={{t}} @columns={{this.columns}} />
+              <EmberTbody @api={{t}} @rows={{this.rows}} @estimateHeigh={{13}} />
+              {{#if this.footerRows}}
+                <EmberTfoot @api={{t}} @rows={{this.footerRows}} />
+              {{/if}}
+            </EmberTable>
+          </div>
+        {{/if}}
+      `);
+
+      this.set('footerRows', generateRows(1));
+
+      this.set('showComponent', false);
+    });
   });
 });