Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: add and use TableRowMeta interface #1108

Merged
merged 1 commit into from
Jul 9, 2024
Merged

types: add and use TableRowMeta interface #1108

merged 1 commit into from
Jul 9, 2024

Conversation

lukasnys
Copy link
Contributor

@lukasnys lukasnys commented Jul 9, 2024

Why?

I'm using the ember-table package with TypeScript and noticed I got errors in my template when I attempted to use any of the rowMeta properties.

What?

Define the TableRowMeta interface based on addon/-private/collapse-tree.js and use it instead of unknown in the type declarations.

@lukasnys lukasnys marked this pull request as ready for review July 9, 2024 13:22
@kpfefferle kpfefferle merged commit dd1a084 into Addepar:master Jul 9, 2024
16 checks passed
@lukasnys
Copy link
Contributor Author

lukasnys commented Jul 9, 2024 •
edited
Loading

@kpfefferle any chance a new minor release could be cut for the changes of this PR as well as for !1106 and !1105?

@lukasnys lukasnys deleted the types/row-meta branch July 10, 2024 10:56
@kpfefferle
Copy link
Member

@lukasnys Released as 6.0.0-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfefferle kpfefferle kpfefferle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasnys @kpfefferle