Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor offsetHeight use float-compat API #948

Merged
merged 1 commit into from
Aug 24, 2023

Commits on Aug 23, 2023

  1. Refactor scale via offsetHeight use precise API

    offsetHeight returns an integer, making it a poor API to base the
    determination of element scale on. Instead, use an alternative and
    precise API. Only allow a reasonable amount of precision by decimal
    place, and for cases where the scale number is reasonably rounded do so.
    
    The offsetHeight method includes padding in returned sizes, where
    getComputedStyle does not. Check them against each other, and if they
    diverge signifcantly (>1) throw an exception.
    
    To make ember-table itself compatible with this appraoch, pass the
    `scale` value around the system a bit more instead of trying to derive
    it in many places.
    mixonic committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3aed24a View commit details
    Browse the repository at this point in the history