Clean up tests ahead of offset fixes #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
mixonic/tests-ahead-of-offset-fix
branch
3 times, most recently
from
38c1853
to
db65823
Compare
mixonic
force-pushed
the
mixonic/tests-ahead-of-offset-fix
branch
2 times, most recently
from
e63c773
to
b898634
Compare
mixonic
force-pushed
the
mixonic/tests-ahead-of-offset-fix
branch
from
b898634
to
955b8b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many places across ember-table's test suite, the idea of an element's logical size (they width according to styles) and the element's rendered size (for example after scaling in the test container) is confused. This is further entangled with mouse operations like
drag, which should emit cursor position atop rendered coordinates although the test may be written with logical units in mind.This PR refactors the header/column reorder and resize tests to use helpers with clearer names and improved implementations. It should improve compatibility of the test suite with upcoming changes to how
scaleis calculated.Largely, these are the test changes needed to get #948 closer to green.