Pull request 2285: fix-test

Squashed commit of the following: commit 006391c Author: Ainar Garipov <[email protected]> Date: Thu Oct 3 14:15:10 2024 +0300 dnsforward: imp test more commit ce743a3 Author: Ainar Garipov <[email protected]> Date: Wed Oct 2 21:13:02 2024 +0300 dnsforward: fix test
AdguardTeam · Oct 3, 2024 · b32b8f9 · b32b8f9
1 parent 355cec1
commit b32b8f9
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/internal/dnsforward/dnsforward_test.go b/internal/dnsforward/dnsforward_test.go
@@ -583,13 +583,15 @@ func TestSafeSearch(t *testing.T) {
 		t.Run(tc.host, func(t *testing.T) {
 			req := createTestMessage(tc.host)
 
+			// TODO(a.garipov):  Create our own helper for this.
 			var reply *dns.Msg
-			require.Eventually(t, func() (ok bool) {
-				reply, _, err = client.Exchange(req, addr)
-
-				return err == nil
+			once := &sync.Once{}
+			require.EventuallyWithT(t, func(c *assert.CollectT) {
+				r, _, errExch := client.Exchange(req, addr)
+				if assert.NoError(c, errExch) {
+					once.Do(func() { reply = r })
+				}
 			}, testTimeout*10, testTimeout)
-			require.NoErrorf(t, err, "couldn't talk to server %s: %s", addr, err)
 
 			if tc.wantCNAME != "" {
 				require.Len(t, reply.Answer, 2)