Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python SDK 4.0 Dev Docs Update #847

Merged
merged 41 commits into from
May 22, 2024
Merged

Python SDK 4.0 Dev Docs Update #847

merged 41 commits into from
May 22, 2024

Conversation

jasnoors
Copy link
Contributor

@jasnoors jasnoors commented May 16, 2024

Python SDK 4.0 Dev Docs Update

Description

Python SDK 4.0 Dev Docs Update

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.


3) At the command line, change to the directory you created, and run the following command to install the Python SDK: `pip install pdfservices-sdk`.

![alt](shot7.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the screenshot, below screenshot show old python version confusing users

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applicable in all 4 locations of quickstarts

@@ -593,7 +593,7 @@ After downloading the zip, you can run the samples in the zip directly by settin

#### Setup a Python environment

1. Install [Python 3.6](https://www.python.org/downloads/) or higher.
1. Install [Python 3.10](https://www.python.org/downloads/) or higher.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect Screenshot only with only extract and autotag mentioned for python.

image

Please fix it at other places for Python as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs level changes will be required under other languages as well for correctness.
Uploading image.png…

@varkumaradobe
Copy link
Contributor

@jasnoors please add screenshot of logs of a working example

image image

mahour and others added 2 commits May 16, 2024 20:36
@jasnoors jasnoors changed the title Python SDK 3.0 Dev Docs Update Python SDK 4.0 Dev Docs Update May 22, 2024
Copy link
Contributor

@varkumaradobe varkumaradobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the screenshots, LGTM.

@jasnoors jasnoors merged commit 46299fd into main May 22, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants