Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts_for_docgen #965

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

charts_for_docgen #965

wants to merge 1 commit into from

Conversation

NamanChhabra
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cfjedimaster
Copy link
Collaborator

I'm really confused by this. When we insert pictures as a placeholder, we edit the ALT data to point to a key in the JSON we send in via API. That allows us to change the url/image etc. In the docs I read here, you edit the chart... by hand... in Excel, which means that you can't pass it in via API and change it later. Right? If I'm right, then how is this a DocGen feature at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants