Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search results not loading #969

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: search results not loading #969

merged 2 commits into from
Nov 6, 2024

Conversation

dmitrymatio
Copy link
Contributor

@dmitrymatio dmitrymatio commented Nov 6, 2024

Description

  • Updated the local Layout component override to utilize the latest search service and fix the search results not loading.
  • Bump theme version to resolve build errors (mainly lottie file errors in build)

Note: I remember an effort to integrate the document-services component overrides into the main theme.
This was supposed to remove the need for the local component overrides, however, it seems that the local files remained which eventually caused diversions between the main theme and this repo. I recommend reviewing the need for those files and hopefully sync with main theme asap. For now this PR resolves the search diversions in Layout.

Related Issue

https://jira.corp.adobe.com/browse/DEVSITE-1402

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hitesh-kumar-mahour hitesh-kumar-mahour merged commit 4060de6 into main Nov 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants