Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Basic Changes (renaming iteration variable, extracting StringFormatter Class, adding explaining variable in JNLP's SimpleRange class, and extracting Interrupted exception logging method) #897

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Refactoring: Basic Changes (renaming iteration variable, extracting StringFormatter Class, adding explaining variable in JNLP's SimpleRange class, and extracting Interrupted exception logging method) #897

wants to merge 7 commits into from

Conversation

sarvang00
Copy link

Hello,

In these commits, I have performed some basic refactoring. The changes include:

  1. Renaming iterationg variable: For better redability (b11d1a4)
  2. Extracting StringFormatter Class from BaseLogger (8aa11c2, e305bef, 3bda723)
  3. Adding an explaining variable in JNLP's SimpleRange class (55275aa)
  4. Extracted Interrupted exception logging method (a6b4efd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sarvang00