change None check and add test for comp

AdrienWehrle · Dec 16, 2024 · 533c2f9 · 533c2f9
1 parent 2dd7d8a
commit 533c2f9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/earthspy/earthspy.py b/earthspy/earthspy.py
@@ -209,10 +209,10 @@ def get_raster_compression(self, raster_compression: Union[None, str]) -> str:
         ]
 
         # use rasterio compression method as is
-        if raster_compression.lower() in rasterio_compression_algorithms:
-            self.raster_compression = raster_compression
-        elif raster_compression is None:
+        if raster_compression is None:
             self.raster_compression = None
+        elif raster_compression.lower() in rasterio_compression_algorithms:
+            self.raster_compression = raster_compression
         else:
             raise KeyError("Compression algorithm not found")
 

diff --git a/tests/test_earthspy.py b/tests/test_earthspy.py
@@ -290,8 +290,11 @@ def test_merge_rasters() -> None:
     # assert len(t3.outputs) == len(t3.split_boxes)
 
 
-# def test_get_raster_compression(t4) -> None:
-#     """"""
-
-#     comp_def = t4.raster_compression()
-#     assert  comp_def == None
+def test_get_raster_compression(t3, t4) -> None:
+    """"""
+
+    comp_def = t3.raster_compression
+    assert  comp_def == None
+
+    comp_cust = t4.raster_compression
+    assert comp_cust == "LZW"