Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADS-7568] docs: storybook for docs app #1524

Merged
merged 1 commit into from
Jul 16, 2023
Merged

[ADS-7568] docs: storybook for docs app #1524

merged 1 commit into from
Jul 16, 2023

Conversation

renrizzolo
Copy link
Contributor

@renrizzolo renrizzolo commented Nov 28, 2022

Description

  • Use Storybook v7 for component documentation
  • Remove old docs and webpack scripts, and packages that are no longer needed

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

plopfile.mjs Fixed Show fixed Hide fixed
plopfile.mjs Fixed Show fixed Hide fixed
plopfile.mjs Fixed Show fixed Hide fixed
plopfile.mjs Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1524 (9361dae) into master (c4c618d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9361dae differs from pull request most recent head 91e7696. Consider uploading reports for the commit 91e7696 to get more accurate results

@@            Coverage Diff            @@
##            master     #1524   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        97    +4     
  Lines         1627      1622    -5     
  Branches       466       452   -14     
=========================================
- Hits          1627      1622    -5     
Impacted Files Coverage Δ
src/components/Button/index.jsx 100.00% <ø> (ø)
src/components/ButtonGroup/index.jsx 100.00% <ø> (ø)
src/components/CountBadge/index.jsx 100.00% <ø> (ø)
src/components/Slicey/index.jsx 100.00% <ø> (ø)
src/components/ActionPanel/index.jsx 100.00% <100.00%> (ø)
src/components/Alert/index.jsx 100.00% <100.00%> (ø)
src/components/Anchor/index.jsx 100.00% <100.00%> (ø)
src/components/Card/index.jsx 100.00% <100.00%> (ø)
src/components/Carousel/index.jsx 100.00% <100.00%> (ø)
src/components/DatePicker/index.jsx 100.00% <100.00%> (ø)
... and 6 more

... and 24 files with indirect coverage changes

@renrizzolo renrizzolo force-pushed the storybook branch 4 times, most recently from fe1ebf0 to f4bc363 Compare December 13, 2022 02:50
romi-h
romi-h previously approved these changes Dec 20, 2022
Copy link
Contributor

@romi-h romi-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

vinteo
vinteo previously approved these changes Dec 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@renrizzolo renrizzolo force-pushed the storybook branch 2 times, most recently from 86148df to f145aa8 Compare March 14, 2023 23:45
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xiaofan2406 xiaofan2406 changed the title Storybook docs: storybook for docs app Jul 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xiaofan2406 xiaofan2406 removed the WIP Work in Progress label Jul 14, 2023
@xiaofan2406 xiaofan2406 self-assigned this Jul 14, 2023
@xiaofan2406 xiaofan2406 merged commit ed96ced into master Jul 16, 2023
17 checks passed
@xiaofan2406 xiaofan2406 deleted the storybook branch July 16, 2023 23:56
@xiaofan2406 xiaofan2406 changed the title docs: storybook for docs app [ADS-7568] docs: storybook for docs app Jul 17, 2023
@robynp robynp mentioned this pull request Jul 18, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants