Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add storybook addons for accessibility #1672

Merged
merged 1 commit into from
Jul 17, 2023
Merged

docs: add storybook addons for accessibility #1672

merged 1 commit into from
Jul 17, 2023

Conversation

JoshuaKlaserAdslot
Copy link
Contributor

@JoshuaKlaserAdslot JoshuaKlaserAdslot commented Jul 13, 2023 •
edited by xiaofan2406
Loading

Adding new addons to the Storybook documentation

Description

Installed several addons into Storybook.:

  • Accessibility (provides a tab that analyses how accessible a component is)

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

Accessibility

image

@JoshuaKlaserAdslot JoshuaKlaserAdslot self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #1672 (6902d0f) into master (ed96ced) will not change coverage.
The diff coverage is n/a.

❗ Current head 6902d0f differs from pull request most recent head 6d42a73. Consider uploading reports for the commit 6d42a73 to get more accurate results

@@            Coverage Diff            @@
##            master     #1672   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines         1627      1627           
  Branches       469       469           
=========================================
  Hits          1627      1627

@xiaofan2406 xiaofan2406 force-pushed the bookstory-addons branch 3 times, most recently from 6789cf8 to 6902d0f Compare July 17, 2023 00:06
@xiaofan2406 xiaofan2406 changed the title Storybook Addons docs: add storybook addons for accessibility Jul 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xiaofan2406 xiaofan2406 merged commit eadd1a5 into master Jul 17, 2023
11 checks passed
@xiaofan2406 xiaofan2406 deleted the bookstory-addons branch July 17, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan2406 xiaofan2406 xiaofan2406 approved these changes

Assignees

@JoshuaKlaserAdslot JoshuaKlaserAdslot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKlaserAdslot @xiaofan2406