Tree picker dts #1686
Merged
Tree picker dts #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tree-picker #1686 +/- ##
============================================
Coverage 99.74% 99.74%
============================================
Files 102 102
Lines 1940 1940
Branches 529 529
============================================
Hits 1935 1935
Misses 5 5
|
chaofan232
force-pushed
the
tree-picker-dts
branch
from
d046c39
to
39bbdb0
Compare
xiaofan2406
reviewed
Sep 28, 2023
| @@ -19,6 +19,7 @@ const HeaderAddAll = () => { | |||
| <Button | |||
| variant="link" | |||
| className="aui--tree-picker-header-add-all" | |||
| dts="add-all-button" | |||
xiaofan2406
reviewed
Sep 28, 2023
| const header = useTreePickerSlice(getCurrentNodeHeader); | ||
|
|
||
| const finalLabel = !_.isUndefined(header) ? header : label; | ||
|
|
||
| return !finalLabel ? null : ( | ||
| <div className={cc('aui--tree-picker-row', 'aui--tree-picker-header', className)}> | ||
| <div className={cc('aui--tree-picker-row', 'aui--tree-picker-header', className)} dts={dts}> |
There was a problem hiding this comment.
data-test-selector={dts}
There was a problem hiding this comment.
use the expandDts util for all places
chaofan232
force-pushed
the
tree-picker-dts
branch
from
39bbdb0
to
c1fcf34
Compare
chaofan232
force-pushed
the
tree-picker-dts
branch
from
c1fcf34
to
58318a4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
xiaofan2406
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):