Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade eslint config #1754

Merged
merged 1 commit into from
Jan 12, 2024
Merged

chore: upgrade eslint config #1754

merged 1 commit into from
Jan 12, 2024

Conversation

xiaofan2406
Copy link
Contributor

@xiaofan2406 xiaofan2406 commented Jan 12, 2024

Description

  • upgrade eslint-config-adslot
  • upgrade lockfile version to 3

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc3db43) 99.74% compared to head (9dbe023) 99.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1754   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         102      102           
  Lines        1940     1940           
  Branches      529      529           
=======================================
  Hits         1935     1935           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bchew bchew merged commit 26bece3 into master Jan 12, 2024
10 checks passed
@bchew bchew deleted the eslint branch January 12, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants