fix: debug interval not working in Search component #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1758 +/- ##
==========================================
- Coverage 99.74% 99.74% -0.01%
==========================================
Files 102 102
Lines 1940 1939 -1
Branches 529 528 -1
==========================================
- Hits 1935 1934 -1
Misses 5 5 ☔ View full report in Codecov by Sentry. |
romi-h
force-pushed
the
fix-search-debounce
branch
from
dfd8b3d
to
ae3b414
Compare
romi-h
force-pushed
the
fix-search-debounce
branch
from
ae3b414
to
aefacab
Compare
|
shn2016
approved these changes
Jan 29, 2024
glenkurniawan-adslot
approved these changes
Jan 29, 2024
|
merging 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that debounce interval is not working in Search Component while i was investigating E2E error in Adslot platform (ADS-8876 and https://github.com/Adslot/direct-web/pull/15879)
Seems like it has been broken for a few years since Adslot/adslot-ui#1048
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):