fix: Allow RichTextEditor and its components to support readOnly state from draftjs editor #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1884 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 94 94
Lines 1865 1868 +3
Branches 552 552
=======================================
+ Hits 1860 1863 +3
Misses 5 5 ☔ View full report in Codecov by Sentry. |
adityasabnis
changed the title
adityasabnis
force-pushed
the
rte-read-only
branch
from
4e9a0dc
to
de6f45b
Compare
|
xiaofan2406
approved these changes
Oct 15, 2024
|
merging 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change leverages Editor's ReadOnly state https://draftjs.org/docs/api-reference-editor#readonly
Description
Accept disabled prop from the component and pass it down to add the moving part of the RichText Editor
When in readOnly state, all the moving part of the RTE should be non-editable. That includes text/ styling / attachments / attachment preview removal
Does this PR introduce a breaking change?
Manual testing step?
Tested:
- New ReadOnly RTE in DW
- Existing Review and Send RTE in DW
Screenshots (if appropriate):
Screen.Recording.2024-10-15.at.3.04.37.pm.mov