-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP server: allow discriminating responses upon requests's starting address #74
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @piertoni,
Thanks for the effort you put into this PR. Your question in #73 and this PR show that the current signature for request handlers is lacking important request information: the starting address and the quantity of the coils/registers that someone requests.
But there is one drawback of this PR: the proposed solution is backwards incompatible. Therefore I am rejecting this PR in this form. I am happy to approve a PR that it adds support for starting_address and quantity in a backwards compatible way.
Where exactly is not compatible? |
I made a workaround to allow passing partial kwargs to app.route decorated functions. Still to do:
|
Just to know if you can check my WIP and if you agree with the idea so I can go on... |
re: failing pipeline, I think 3.3 and 3.4 support should be dropped as they are EOL https://devguide.python.org/devcycle/#end-of-life-branches |
First working code to address #73
It adds an optional argument to server that allows to discriminate between requests.
Example of server:
Result on client
If you are ok with the proposal I can go on finishing with a automatic test and documentation.
As you did before, please give me a quick advice to where put my hand for implement the tests.