-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multislice rPIE ready for main branch after testing Daniel's reworkng of multiGPU workflow #332
Conversation
…g of multiGPU workflow
Hello @a4894z! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Purpose
After extensive testing on various benchmarking datasets (experimental and simulated), I believe multislice rPIE is ready to be merged into the main branch of TIKE.
Approach
The preconditioners are calculated for each slice in the sample, and these are then used in the sample update for each slice in a 3PIE style of update and the probe is updated using only the first slice of the sample and probe...this is a similar scheme that fold_slice uses in their LSTSQ multislice solver.
Pre-Merge Checklists
Submitter
Reviewer