Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State management changes - MBway #1975

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

State management changes - MBway #1975

wants to merge 32 commits into from

Conversation

araratthehero
Copy link
Contributor

Description

  • Move state outside of views

Checklist

  • If applicable, make sure Breaking change label is added.
  • Code is unit tested
  • Changes are tested manually
  • Related issues are linked

COAND-935

@araratthehero araratthehero force-pushed the refactor/improve_state_handling_for_views_mbway branch from def0ef7 to aa2f749 Compare January 29, 2025 09:32
OscarSpruit
OscarSpruit reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@OscarSpruit OscarSpruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but a bit complicated. Maybe you can walk us through it soon?

mbway/src/main/java/com/adyen/checkout/mbway/internal/ui/DefaultMBWayDelegate.kt Outdated Show resolved Hide resolved
@araratthehero
Remove input data
26e5f78 
COAND-935
@araratthehero
Remove outputData and use MBWayViewState instead
f847490 
Create FieldValidator to validate fields in the Delegate side

COAND-935
@araratthehero
Separate view state from view model state
96f5d91 
Add field focus changed events and update view state

COAND-935
@araratthehero
Rename state files to delegateState to keep them separate from viewState
885dfda 
COAND-935
@araratthehero
Observe submitHandler to validate all fields when Submit button is cl…
4ee4bba 
…icked and the input is not valid

COAND-935
@araratthehero
Optimise updating field values in delegate
133bee0 
COAND-935
@araratthehero
Update viewState every time delegateState updates, instead of trigger…
396e1ce 
…ing it manually

COAND-935
@araratthehero
Add isValidationErrorCheckForced flag, to show validation error messa…
201920d 
…ges, regardless the focus state. This happens when the Submit button is clicked.

COAND-935
@araratthehero
Provide countries and initiallySelectedCountry from the delegate
915871a 
COAND-935
@araratthehero
Do minor optimizations
9fc1a8f 
COAND-935
@araratthehero
Generate component state when delegate state gets updated
4514c3f 
COAND-935
@araratthehero
Focus the first invalid field when Submit button is clicked and make …
750e340 
…sure that the error message does not hid

COAND-935
@araratthehero
Implement FieldTransformerRegistry, which will transform field values…
b0ea4d8 
… for validation and data manipulation

COAND-935
@araratthehero
Update phone number text when received from the delegate
6a25504 
COAND-935
@araratthehero
Improve MBWayValidatorRegistry logic where not implementing a new Fie…
f6dbd17 
…ldId will cause a compile time error

COAND-935
@araratthehero
Add todos
117ead2 
COAND-935
@araratthehero
Support different types for updateField function
779265c 
Create a state for country code field

COAND-935
@araratthehero
Remove unnecessary flag for keeping the error message visible and ins…
30a4e91 
…tead remove and add change listeners in the view

COAND-935
@araratthehero
Improve onSubmit() function by highlighting validation errors if the …
e398b08 
…state is invalid

COAND-935
@araratthehero
Move each state related logic to their own files
0cf2491 
COAND-935
@araratthehero
Create UI event delegate for delegates
dd42832 
COAND-935
@araratthehero
Improve MBWayTransformerRegistry to show compile time error if a new …
ff0a0f5 
…field id gets added

COAND-935
@araratthehero
Create StateUpdaterRegistry and StateManager to handle all state updates
2ea4b09 
COAND-935
@araratthehero
Move state to the StateManager
e3d713d 
COAND-935
@araratthehero
Fix MBWayComponentProvider
06f7367 
COAND-935
@araratthehero
Move highlightAllFieldValidationErrors to StateManager
30d6f57 
COAND-935
@araratthehero
Fix onFieldValueChanged function to adopt generics
2c55566 
COAND-935
@araratthehero
Use stateManager directly instead of a helper function
84b1f5b 
COAND-935
@araratthehero araratthehero force-pushed the refactor/improve_state_handling_for_views_mbway branch from da9bf69 to b2249f5 Compare February 4, 2025 14:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

✅ No public API changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OscarSpruit OscarSpruit OscarSpruit left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@araratthehero @OscarSpruit