Skip to content

Commit

Permalink
Update component's separator layout.
Browse files Browse the repository at this point in the history
# Summary

- Update the component's separator layout in order to be centered within
the container view.
- Pin card logo's edges to the card number field's edges.

# Demo

| Before | Update |
| --- | --- |
| ![Simulator Screenshot - iPhone 16 Pro - 2025-02-25 at 14 38
05](https://github.com/user-attachments/assets/f9c3bcc4-d472-4a6a-b3f3-be2d7b4f8584)
| ![Simulator Screenshot - iPhone 16 Pro - 2025-02-26 at 11 56
53](https://github.com/user-attachments/assets/83c8b3d3-f120-4be3-8f9f-bbfe49491f8b)
|

# Release notes

<fixed> 

- Update the component's separator layout in order to be centered within
the container view.
- Pin card logo's edges to the card number field's edges.

</fixed>

# Ticket

<ticket>
COIOS-000
</ticket>
  • Loading branch information
nauaros authored Mar 3, 2025
2 parents 9a4a180 + cccdbf7 commit 676697d
Show file tree
Hide file tree
Showing 185 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Adyen/UI/Form/Items/Split/FormSplitItemView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ internal final class FormSplitItemView: FormItemView<FormSplitItem> {
stackView.axis = .horizontal
stackView.alignment = .top
stackView.distribution = .fillEqually
stackView.spacing = 16
stackView.spacing = 0
return stackView
}()

Expand Down
2 changes: 1 addition & 1 deletion Adyen/UI/Form/Items/Text/FormTextItemView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ open class FormTextItemView<ItemType: FormTextItem>: FormValidatableValueItemVie
override open func configureSeparatorView() {
let constraints = [
separatorView.leadingAnchor.constraint(equalTo: layoutMarginsGuide.leadingAnchor),
separatorView.trailingAnchor.constraint(equalTo: trailingAnchor),
separatorView.trailingAnchor.constraint(equalTo: layoutMarginsGuide.trailingAnchor),
separatorView.heightAnchor.constraint(equalToConstant: 1.0)
]

Expand Down
2 changes: 1 addition & 1 deletion Adyen/UI/Form/Items/Value/FormValueItemView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ open class FormValueItemView<ValueType, Style, ItemType: FormValueItem<ValueType
open func configureSeparatorView() {
let constraints = [
separatorView.leadingAnchor.constraint(equalTo: layoutMarginsGuide.leadingAnchor),
separatorView.trailingAnchor.constraint(equalTo: trailingAnchor),
separatorView.trailingAnchor.constraint(equalTo: layoutMarginsGuide.trailingAnchor),
separatorView.bottomAnchor.constraint(equalTo: bottomAnchor),
separatorView.heightAnchor.constraint(equalToConstant: 1.0)
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ open class FormValidatableValueItemView<ValueType, ItemType: FormValidatableValu
override open func configureSeparatorView() {
let constraints = [
separatorView.leadingAnchor.constraint(equalTo: layoutMarginsGuide.leadingAnchor),
separatorView.trailingAnchor.constraint(equalTo: trailingAnchor),
separatorView.trailingAnchor.constraint(equalTo: layoutMarginsGuide.trailingAnchor),
separatorView.heightAnchor.constraint(equalToConstant: 1.0)
]

Expand Down
2 changes: 1 addition & 1 deletion AdyenCard/Form/FormCardLogosItemView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ internal final class FormCardLogosItemView: FormItemView<FormCardLogosItem>, UIC
internal required init(item: FormCardLogosItem) {
super.init(item: item)
addSubview(collectionView)
collectionView.adyen.anchor(inside: self, with: UIEdgeInsets(top: 4, left: 16, bottom: 8, right: 16))
collectionView.adyen.anchor(inside: self.layoutMarginsGuide)
collectionView.register(CardLogoCell.self, forCellWithReuseIdentifier: CardLogoCell.reuseIdentifier)
collectionView.dataSource = self
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 676697d

Please sign in to comment.