Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new Detached address input #1501

Merged
merged 27 commits into from
Jan 25, 2024
Merged

new Detached address input #1501

merged 27 commits into from
Jan 25, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Jan 9, 2024 •
edited
Loading

Changes

For all payment methods that include input fields for the shopper's address, the address input fields are now on a separate screen. This declutters the payment screen to improve user experience.

Summary

  • Moves address input to a separate screen for ACH, Affirm, ...
  • Moving cocoapods + carthage tests to an xl runner
  • Fixed demo app settings look for iPad

github-actions[bot]
github-actions bot requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn goergisn added the changed a pull request that changed some thing label Jan 12, 2024
github-actions[bot]
github-actions bot previously approved these changes Jan 12, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2024
View reviewed changes
@goergisn goergisn requested a review from erenbesel January 17, 2024 10:39
@goergisn goergisn marked this pull request as ready for review January 17, 2024 10:39
descorp
descorp previously approved these changes Jan 17, 2024
View reviewed changes
@goergisn goergisn dismissed stale reviews from github-actions[bot] and descorp via af0be18 January 17, 2024 15:25
github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2024
View reviewed changes
@goergisn goergisn requested a review from atmamont January 17, 2024 15:33
github-actions[bot]
github-actions bot previously approved these changes Jan 18, 2024
View reviewed changes
atmamont
atmamont previously approved these changes Jan 18, 2024
View reviewed changes
@goergisn goergisn dismissed stale reviews from atmamont and github-actions[bot] via ecf19b5 January 18, 2024 14:31
@goergisn goergisn requested a review from atmamont January 23, 2024 08:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
92.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@goergisn goergisn merged commit 3395c97 into develop Jan 25, 2024
11 of 12 checks passed
@goergisn goergisn deleted the detached_address_input branch January 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nauaros nauaros nauaros approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@neelSharma12 neelSharma12 neelSharma12 approved these changes

@erenbesel erenbesel Awaiting requested review from erenbesel

@descorp descorp Awaiting requested review from descorp

@atmamont atmamont Awaiting requested review from atmamont

Assignees
No one assigned
Labels
changed a pull request that changed some thing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@goergisn @descorp @nauaros @atmamont @neelSharma12