Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore Adding snapshot tests for SecuredViewController #1508

Merged
merged 3 commits into from
Jan 26, 2024
Merged

chore Adding snapshot tests for SecuredViewController #1508

merged 3 commits into from
Jan 26, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Jan 25, 2024 •
edited
Loading

Summary

  • Adding snapshot tests for SecuredViewController
  • Drawing the hierarchy into the keyWindow to be able to capture UIVisualEffectView

github-actions[bot]
github-actions bot requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn
Merge branch 'develop' into feature/better_snapshot_tests
965c575 
# Conflicts:
#	Adyen.xcodeproj/project.pbxproj
#	UITests/Components/Affirm/__Snapshots__/AffirmComponentUITests/testAffirmPrefilling_givenDeliveryAddressIsNotSet-iPhone12.shopper-info-prefilled-address-not-set.png
#	UITests/Components/Affirm/__Snapshots__/AffirmComponentUITests/testAffirmPrefilling_givenDeliveryAddressIsSet-iPhone12.shopper-info-prefilled-address-set.png
#	UITests/Components/Affirm/__Snapshots__/AffirmComponentUITests/testAffirm_givenNoShopperInformation_shouldNotPrefill-iPhone12.shopper-info-not-filled.png
#	UITests/Components/Affirm/__Snapshots__/AffirmComponentUITests/testSubmitForm_shouldCallDelegateWithProperParameters-iPhone12.shopper-info-prefilled.png
#	UITests/Components/Boleto/__Snapshots__/BoletoComponentUITests/testPaymentDataNoName-iPhone12.boleto_flow_no_name.png
#	UITests/Components/Boleto/__Snapshots__/BoletoComponentUITests/testUIConfiguration-iPhone12.UI_configuration.png
#	UITests/Helpers/XCTestCase+SnapshotTesting.swift
@goergisn
Updating snapshots
c372ab8
@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Jan 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@goergisn goergisn merged commit ed32cda into develop Jan 26, 2024
12 of 13 checks passed
@goergisn goergisn deleted the feature/better_snapshot_tests branch January 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@descorp descorp descorp approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@neelSharma12 neelSharma12 neelSharma12 approved these changes

@erenbesel erenbesel Awaiting requested review from erenbesel

@nauaros nauaros Awaiting requested review from nauaros

@atmamont atmamont Awaiting requested review from atmamont

Assignees
No one assigned
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goergisn @descorp @neelSharma12