Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AdyenAction tests for Twint #1550

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Adding AdyenAction tests for Twint #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions AdyenTwint/TwintComponent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,32 +13,25 @@ import TwintSDK

public final class TwintComponent: PaymentComponent {

/// Configuration for Twint Component.
public typealias Configuration = BasicComponentConfiguration

/// The context object for this component.
@_spi(AdyenInternal)
public var context: AdyenContext
public let context: AdyenContext

/// The payment method object for this component.
public var paymentMethod: PaymentMethod { twintPaymentMethod }

private let twintPaymentMethod: TwintPaymentMethod

public var requiresModalPresentation: Bool = true
public let paymentMethod: PaymentMethod

/// The ready to submit payment data.
public let paymentData: PaymentComponentData

/// Configuration for Twint Component.
public typealias Configuration = BasicComponentConfiguration

/// Component's configuration
public var configuration: Configuration

/// The delegate of the component.
public weak var delegate: PaymentComponentDelegate?

// List of installed Twint apps on the device
private let installedApps: [TWAppConfiguration] = []

/// Initializes the Twint component.
///
/// - Parameter paymentMethod: The Twint payment method.
Expand All @@ -47,11 +40,11 @@ public final class TwintComponent: PaymentComponent {
public init(paymentMethod: TwintPaymentMethod,
context: AdyenContext,
configuration: Configuration = .init()) {
self.twintPaymentMethod = paymentMethod
self.paymentMethod = paymentMethod
self.context = context
self.configuration = configuration

let details = TwintDetails(type: twintPaymentMethod,
let details = TwintDetails(type: paymentMethod,
subType: "sdk")
self.paymentData = PaymentComponentData(paymentMethodDetails: details,
amount: context.payment?.amount,
Expand Down
90 changes: 83 additions & 7 deletions Tests/Actions Tests/ActionComponent/AdyenActionComponentTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import AdyenWeChatPay
import SafariServices
import XCTest

#if canImport(AdyenTwint)
import AdyenTwint
#endif

class AdyenActionComponentTests: XCTestCase {

let weChatActionResponse = """
Expand Down Expand Up @@ -73,6 +77,17 @@ class AdyenActionComponentTests: XCTestCase {
"url": "https://adyen.com"
}
"""

let twintAction = """
{
"paymentMethodType": "twint",
"paymentData": "",
"type": "sdk",
"sdkData": {
"token": ""
}
}
"""

func testRedirectToHttpWebLink() throws {
let sut = AdyenActionComponent(context: Dummy.context)
Expand Down Expand Up @@ -111,7 +126,7 @@ class AdyenActionComponentTests: XCTestCase {
waitForExpectations(timeout: 100, handler: nil)
}

func testWeChatAction() {
func testWeChatAction() throws {
let sut = AdyenActionComponent(context: Dummy.context)

let expectation = expectation(description: "Assertion Expectation")
Expand All @@ -122,15 +137,15 @@ class AdyenActionComponentTests: XCTestCase {
expectation.fulfill()
}

let sdkAction = try! JSONDecoder().decode(SDKAction.self, from: weChatActionResponse.data(using: .utf8)!)
let sdkAction = try JSONDecoder().decode(SDKAction.self, from: weChatActionResponse.data(using: .utf8)!)
sut.handle(Action.sdk(sdkAction))

waitForExpectations(timeout: 15, handler: nil)
}

func test3DSAction() {
func test3DSAction() throws {
let sut = AdyenActionComponent(context: Dummy.context)
let action = try! JSONDecoder().decode(ThreeDS2Action.self, from: threeDSFingerprintAction.data(using: .utf8)!)
let action = try JSONDecoder().decode(ThreeDS2Action.self, from: threeDSFingerprintAction.data(using: .utf8)!)
sut.handle(Action.threeDS2(action))

wait { sut.currentActionComponent is ThreeDS2Component }
Expand All @@ -140,7 +155,7 @@ class AdyenActionComponentTests: XCTestCase {
let sut = AdyenActionComponent(context: Dummy.context)
sut.presentationDelegate = try UIViewController.topPresenter()

let action = try! JSONDecoder().decode(VoucherAction.self, from: voucherAction.data(using: .utf8)!)
let action = try JSONDecoder().decode(VoucherAction.self, from: voucherAction.data(using: .utf8)!)
sut.handle(Action.voucher(action))

let waitExpectation = expectation(description: "Expect VoucherViewController to be presented")
Expand All @@ -161,7 +176,7 @@ class AdyenActionComponentTests: XCTestCase {
let sut = AdyenActionComponent(context: Dummy.context)
sut.presentationDelegate = try UIViewController.topPresenter()

let action = try! JSONDecoder().decode(QRCodeAction.self, from: qrAction.data(using: .utf8)!)
let action = try JSONDecoder().decode(QRCodeAction.self, from: qrAction.data(using: .utf8)!)
sut.handle(Action.qrCode(action))

try waitUntilTopPresenter(isOfType: QRCodeViewController.self)
Expand All @@ -172,10 +187,71 @@ class AdyenActionComponentTests: XCTestCase {
let sut = AdyenActionComponent(context: Dummy.context)
sut.presentationDelegate = try UIViewController.topPresenter()

let action = try! JSONDecoder().decode(DocumentAction.self, from: documentAction.data(using: .utf8)!)
let action = try JSONDecoder().decode(DocumentAction.self, from: documentAction.data(using: .utf8)!)
sut.handle(Action.document(action))

let documentViewController = try waitUntilTopPresenter(isOfType: ADYViewController.self)
XCTAssertNotNil(documentViewController.view as? DocumentActionView)
}

func testTwintAction() throws {

let sut = AdyenActionComponent(context: Dummy.context)
sut.presentationDelegate = try UIViewController.topPresenter()

let assertionExpectation = expectation(description: "Should Assert if no Twint configuration is provided")
AdyenAssertion.listener = { assertion in
XCTAssertEqual(assertion, "Twint action configuration instance must not be nil in order to use AdyenTwint")
assertionExpectation.fulfill()
}

let action = try JSONDecoder().decode(TwintSDKAction.self, from: twintAction.data(using: .utf8)!)
sut.handle(Action.sdk(.twint(action)))

wait(for: [assertionExpectation], timeout: 0.1)

AdyenAssertion.listener = nil

let expectedCallbackAppScheme = "ui-host"
sut.configuration.twint = .init(callbackAppScheme: expectedCallbackAppScheme)
sut.handle(Action.sdk(.twint(action)))

#if canImport(AdyenTwint)
let twintComponent = try XCTUnwrap(sut.currentActionComponent as? TwintSDKActionComponent)
XCTAssertEqual(twintComponent.configuration.callbackAppScheme, expectedCallbackAppScheme)
#endif
}

func testTwintActionConfiguration() throws {

let validSchemes = [
"scheme"
]

let invalidSchemes = [
"scheme:",
"scheme://",
"scheme://host"
]

// Valid Configuration

validSchemes.forEach { scheme in
AdyenAssertion.listener = { message in
XCTFail("No assertion should have been raised")
}

let _ = AdyenActionComponent.Configuration.Twint(callbackAppScheme: scheme)
}

// Invalid Configuration

invalidSchemes.forEach { scheme in
AdyenAssertion.listener = { message in
XCTAssertEqual(message, "Format of provided callbackAppScheme '\(scheme)' is incorrect.")
}

let _ = AdyenActionComponent.Configuration.Twint(callbackAppScheme: scheme)
}
}
}
33 changes: 0 additions & 33 deletions Tests/Actions Tests/ActionComponent/Twint/TwintSDKActionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,39 +20,6 @@ final class TwintSDKActionTests: XCTestCase {
AdyenAssertion.listener = nil
}

func testConfiguration() throws {

let validSchemes = [
"scheme"
]

let invalidSchemes = [
"scheme:",
"scheme://",
"scheme://host"
]

// Valid Configuration

validSchemes.forEach { scheme in
AdyenAssertion.listener = { message in
XCTFail("No assertion should have been raised")
}

let _ = AdyenActionComponent.Configuration.Twint(callbackAppScheme: scheme)
}

// Invalid Configuration

invalidSchemes.forEach { scheme in
AdyenAssertion.listener = { message in
XCTAssertEqual(message, "Format of provided callbackAppScheme '\(scheme)' is incorrect.")
}

let _ = AdyenActionComponent.Configuration.Twint(callbackAppScheme: scheme)
}
}

func testNoAppFound() throws {

let fetchBlockExpectation = expectation(description: "Fetch was called")
Expand Down
Loading