Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup for payto #2000

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

neelSharma12
Copy link
Contributor

Summary

- Added initial setup for payTo payment method.

Ticket

COIOS-863

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

Copy link
Contributor

@erenbesel erenbesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tiny comment for testing

@neelSharma12 neelSharma12 changed the title initial setup for payto Initial setup for payto Jan 31, 2025
@neelSharma12 neelSharma12 changed the base branch from develop to payto-base January 31, 2025 12:57
@neelSharma12 neelSharma12 marked this pull request as ready for review January 31, 2025 12:58
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
37.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@neelSharma12 neelSharma12 merged commit 1f61ddf into payto-base Feb 3, 2025
8 of 10 checks passed
@neelSharma12 neelSharma12 deleted the feature-payto-initial-setup branch February 3, 2025 09:18
Copy link
Contributor

github-actions bot commented Feb 3, 2025

👀 3 public changes detected

Comparing feature-payto-initial-setup to payto-base

❇️3 Additions

Adyen

❇️ Added

public struct PayToPaymentMethod: Adyen.PaymentMethod {
  public func encode(to encoder: any Swift.Encoder) throws -> Swift.Void
  public init(from decoder: any Swift.Decoder) throws
  public let name: Swift.String { get }
  public let type: Adyen.PaymentMethodType { get }
  public var merchantProvidedDisplayInformation: Adyen.MerchantCustomDisplayInformation?
}

PaymentMethodType

❇️ Added

case payto

AdyenComponents

❇️ Added

final public class PayToComponent: Adyen.PaymentComponent, Adyen.PresentableComponent {
  final public var configuration: AdyenComponents.PayToComponent.Configuration
  final public var paymentMethod: any Adyen.PaymentMethod { get }
  final public var viewController: UIKit.UIViewController { get set }
  public init(
    paymentMethod: Adyen.PayToPaymentMethod,
    context: Adyen.AdyenContext,
    configuration: AdyenComponents.PayToComponent.Configuration = .init()
  )
  public typealias Configuration = Adyen.BasicComponentConfiguration
  weak final public var delegate: (any Adyen.PaymentComponentDelegate)?
}

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants