Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base UI for payTo #2004

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Base UI for payTo #2004

merged 2 commits into from
Feb 4, 2025

Conversation

neelSharma12
Copy link
Contributor

Summary

Base UI including following:
  1. PayTo title text
  2. PayTo flow type selection title text
  3. Segmented control item including 1. PayID 2.BSB
  4. Continue button

Demo

Simulator Screenshot - iPhone 16 - 2025-02-03 at 09 36 59

Ticket

COIOS-864

github-actions[bot]
github-actions bot requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

erenbesel
erenbesel approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@erenbesel erenbesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but tiny comment :)

@atmamont
Copy link
Contributor

atmamont commented Feb 4, 2025

+1 to have pipeline always green

@neelSharma12 neelSharma12 merged commit d365eaf into payto-base Feb 4, 2025
8 of 10 checks passed
@neelSharma12 neelSharma12 deleted the initial-ui-setup branch February 4, 2025 12:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👀 1 public change detected

Comparing initial-ui-setup to payto-base

❇️1 Addition

AdyenComponents

PayToComponent

❇️ Added

final public var requiresModalPresentation: Swift.Bool

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

@neelSharma12 neelSharma12 restored the initial-ui-setup branch February 4, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmamont atmamont atmamont left review comments

@github-actions github-actions[bot] github-actions[bot] requested changes

@erenbesel erenbesel erenbesel approved these changes

@goergisn goergisn Awaiting requested review from goergisn

@nauaros nauaros Awaiting requested review from nauaros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neelSharma12 @atmamont @goergisn @erenbesel