Integrate card scanning - part 1 #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary <changed> - For [native 3D Secure 2](https://docs.adyen.com/online-payments/3d-secure/native-3ds2/?platform=iOS&integration=Drop-in&version=5.0.0+and+later), when a shopper cancels the payment during the payment flow, the `didProvide(...`) delegate method is now triggered. What this means for your integration depends on whether you already make a `/payments/details` call to handle 3D Secure 2 errors: - If yes, you do not need to make any changes to your integration. - If not, update your integration to make a `/payments/details` request to get the details of the canceled transaction. </changed> # Ticket <ticket> COIOS-855 </ticket>
# Summary Our current system to build accessibility identifier in runtime doesn't really work nicely when root view doesn't have an identifier. `PreApplePayView` is an "orphan" view that is presented using abstract `ADYViewController` and doesn't have and shouldn't have any accessibility logic. It's up to a child view to decide and while we don't have many such cases, it seems to be one of them. ## Before `<Adyen.PreApplePayView: 0x103374f00; frame = (0 0; 0 0); layer = <CALayer: 0x60000036b900>>.applePayButton` ## After `adyen.preApplePay.applePayButton` # Ticket <ticket> COIOS-000 </ticket>
# Summary - Creating (empty) prepare_release.yml - Removing formatting workflow (happens on every PR) - Fixed workflow typo # Ticket <ticket> COIOS-000 </ticket> --------- Co-authored-by: Alex Guretzki <[email protected]>
# Summary - Restoring build.yml (Compatibility Tests) - renamed to `verify-older-os-compatibility.yml` # Ticket <ticket> COIOS-000 </ticket> --------- Co-authored-by: Alex Guretzki <[email protected]>
# Summary - Creates a Draft Release once a `release/*` branch is merged via a PR ## Release Workflow - Use [prepare_release](https://github.com/Adyen/adyen-ios/actions/workflows/prepare_release.yml) action to initiate the release workflow - Branches off the specified base branch into a `release/[version_number]` - Creates a PR to the base branch - Once the PR is updated with the updated release notes (in the PR body) and merged, a draft release is created - **[Introduced by this PR]** - Once the draft release is merged the [post_release](https://github.com/Adyen/adyen-ios/actions/workflows/post_release.yml) is triggered - Uploads updated Demo App - Publishes podspec - Deploys docs # Ticket <ticket> COIOS-000 </ticket> --------- Co-authored-by: Alex Guretzki <[email protected]>
# Summary - Using escaping for release notes instead of a token - Improving output <ticket>COIOS-000</ticket>
#2009) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Adyen/adyen-swift-public-api-diff](https://redirect.github.com/Adyen/adyen-swift-public-api-diff) | action | patch | `0.8.1` -> `0.8.3` | --- ### Release Notes <details> <summary>Adyen/adyen-swift-public-api-diff (Adyen/adyen-swift-public-api-diff)</summary> ### [`v0.8.3`](https://redirect.github.com/Adyen/adyen-swift-public-api-diff/releases/tag/0.8.3) [Compare Source](https://redirect.github.com/Adyen/adyen-swift-public-api-diff/compare/0.8.2...0.8.3) #### What's Changed - Correctly handling target resources by [@​goergisn](https://redirect.github.com/goergisn) in [https://github.com/Adyen/adyen-swift-public-api-diff/pull/98](https://redirect.github.com/Adyen/adyen-swift-public-api-diff/pull/98) - Package analyzer fixes by [@​goergisn](https://redirect.github.com/goergisn) in [https://github.com/Adyen/adyen-swift-public-api-diff/pull/100](https://redirect.github.com/Adyen/adyen-swift-public-api-diff/pull/100) **Full Changelog**: Adyen/adyen-swift-public-api-diff@0.8.2...0.8.3 ### [`v0.8.2`](https://redirect.github.com/Adyen/adyen-swift-public-api-diff/releases/tag/0.8.2) [Compare Source](https://redirect.github.com/Adyen/adyen-swift-public-api-diff/compare/0.8.1...0.8.2) #### Summary - Removing false duplicates for platform in `Package.swift` - Adding `Target.Resource`s diffing **Full Changelog**: Adyen/adyen-swift-public-api-diff@0.8.1...0.8.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/Adyen/adyen-ios). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjQuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE2NC4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJjaG9yZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# Summary - Targeting `AdyenNetworking` [3.0.0](https://github.com/Adyen/adyen-networking-ios/releases/tag/3.0.0) - Adjusting the code to accommodate the changes ## Release Notes <changed> Update AdyenNetworking to v3.0.0 </changed> # Ticket <ticket> COIOS-000 </ticket> Co-authored-by: Alex Guretzki <[email protected]>
# Summary - Release script checks for release branch and skips steps instead of failing # Ticket <ticket> COIOS-000 </ticket>
# Summary - No additional file gets created on release preparation # Ticket <ticket> COIOS-000 </ticket> --------- Co-authored-by: Alex Guretzki <[email protected]>
…to feature/COIOS-827-integrate-card-scanning
…rmCardNumberItem`
atmamont
added
the
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nauaros
approved these changes
Mar 5, 2025
erenbesel
approved these changes
Mar 5, 2025
neelSharma12
approved these changes
Mar 5, 2025
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change:
UITextField(card number) keyboardFormCardNumberItemrespecting currentFormViewControllerarchitectureUML diagram
Demo
Ticket
COIOS-Next steps