fix(exception): better handle non-JSON response bodies #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndlessNexusPrime
approved these changes
Dec 10, 2024
|
@sp00m Thank you for the contribution. It is a useful change, but the unit test fails. Can you maybe have a look? Thank you |
The unit tests do pass, it's your SonarCloud pipeline that seems to fail because somehow misconfigured? |
gcatanese
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs and the response body isn't JSON (e.g. a misconfiguration of the base path triggering an HTML error page as a response), the code swallows the original error and instead throws a parsing exception.
This PR ensures parsing exceptions are ignored so that the original issue remains available.