Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-8675v9] Undefined array key "pspreference" in TransactionCapture #2304

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

RokPopov
Copy link
Contributor

@RokPopov RokPopov commented Oct 24, 2023

Description
If capture response doesn't contain pspreference, catch block fails here. This PR checks if the PSP reference is set and handles the exception message accordingly if it isn't.

Tested scenarios

  • process the capture request without the PSP reference

Fixes #2251

@RokPopov RokPopov requested a review from a team as a code owner October 24, 2023 15:02
@RokPopov RokPopov merged commit adf0de7 into develop Oct 26, 2023
3 of 4 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 133 Code Smells

22.9% 22.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@RokPopov RokPopov mentioned this pull request Oct 26, 2023
@dufrygrant
Copy link

Can this please be added into the 'stable' 8.x branch, as this is where it was originally reported and where there are PROD installations being unable to capture as a result?

@aziya-im From our perspective it's more important to have this in the versions typically installed in PROD today than a branch that isn't widely deployed yet (9.x). This was word-for-word the exact same problem (prioritisation of merge into a new branch over the widely deployed one) we reported via Sven in October 2021 and despite receiving assurances at the time that such reported issues would be treated a certain way, this is apparently not happening. 8.22.2 is now two weeks old. C'mon!

@RokPopov
Copy link
Contributor Author

RokPopov commented Oct 30, 2023

Hi @dufrygrant,

Thank you for your feedback, this is much appreciated. However, please know we also created a PR for v8 which will be released this week according to our regular release schedule. You can check it out here.

Cheers,
Rok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ECP-8675] Warning: Undefined array key "pspreference"
4 participants