Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added factory classes as dependencies for CLI Command #2387

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Added factory classes as dependencies for CLI Command #2387

merged 2 commits into from
Dec 21, 2023

Conversation

pawel-ledwig
Copy link
Contributor

@pawel-ledwig pawel-ledwig commented Dec 11, 2023 •
edited
Loading

Description
During installation of Magento from a scratch, there is an exception thrown:

[Progress: 4 / 1931]
Installing database schema:

In WebsiteRepository.php line 159:

  [DomainException]
  The default website isn't defined. Set the website and try again.

It is caused by CLI Command class dependencies that uses ScopeConfig.
In order to fix the issue, there should be used Factory classes as CLI dependencies.

Closes #2388

@pawel-ledwig pawel-ledwig requested a review from a team as a code owner December 11, 2023 07:03
@pawel-ledwig pawel-ledwig mentioned this pull request Dec 11, 2023
Closed
@hossam-adyen
Copy link
Contributor

test pipelines with mirror draft #2406

@hossam-adyen hossam-adyen merged commit 9761c34 into Adyen:develop Dec 21, 2023
2 of 6 checks passed
@candemiralp candemiralp mentioned this pull request Dec 27, 2023
Merged
@candemiralp candemiralp mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RokPopov RokPopov RokPopov approved these changes

@hossam-adyen hossam-adyen hossam-adyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The default website isn't defined - missing Factory classes in a CLI Command
3 participants
@pawel-ledwig @hossam-adyen @RokPopov