fix: Missing dependencies / setup fails on new installations

[pmzandbergen]

Missing dependency may cause new installations to fail.

See: #1431 (comment)

Fixes:

• In 9.2.0 the setup:install command fails when running the Adyen_Payment schema recurring #2526
• [ECP-8912][PW-7149] - POS terminal Payment Notification for non-existing Order #1431

test coverage

[pmzandbergen]

@hossam-adyen these problems were introduced by: #2476

@bramstroker will add the details

[bramstroker]

Narrowed down the issue to be in https://github.com/Adyen/adyen-magento2/blob/develop/Setup/Recurring.php

During execution of the recurring schema the following components will be constructed by DI container:

• \Adyen\Payment\Setup\Recurring
• \Adyen\Payment\Helper\PaymentMethodsFactory
• \Adyen\Payment\Helper\Data
• \Magento\Tax\Model\Calculation
• \Magento\Customer\Model\Session
• \Magento\Customer\Model\ResourceModel\Customer

Construction of Customer resource calls setType and fails with following exception, thus crashing Magento installation.

Invalid entity_type specified: customer

The eav entity types are created by data patch in Magento_Customer module, and data patches are being executed after recurring schema.

The question is why this is in recurring schema in the first place as it has nothing to do with DB schema. It just sets some config settings.

So the solution seems to me to execute this logic in a data patch, which ultimately also has a dependency on the Magento data patch which creates the eav_entity_type records. \Magento\Customer\Setup\Patch\Data\DefaultCustomerGroupsAndAttributes

[hossam-adyen]

Hi @pmzandbergen, thanks for your valuable contribution and dedicate time for opening this draft and providing this fix, please let us know when it's ready for review.

If you also don't mine, please update the unit test file to avoid the failure of the PR checks

[pmzandbergen]

Hi @pmzandbergen, thanks for your valuable contribution and dedicate time for opening this draft and providing this fix, please let us know when it's ready for review.

If you also don't mine, please update the unit test file to avoid the failure of the PR checks

Have a look at: #2509 (comment)

[bramstroker]

I have changed current Recurring schema script, to RecurringData, which solves our problems.

Workflow for CI/CD testing pipeline in our projects is as follows:

• composer install using existing composer.lock file, containing both magento installation and 3rd party modules (also the adyen module).
• bin/magento setup:install

This fails without the fixes provided in this PR.

It would be nice if similar procedure also can be verified in you QA pipeline, as it's not the first time our CI/CD pipelines break after (minor) upgrade of Adyen module.

[bramstroker]

Can this be merged please so it can be part of upcoming release?
This currently blocks updates for the module for our clients.
Don't like to put any temporary composer patches to work around the issue.