-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missing dependencies / setup fails on new installations #2509
Conversation
Missing dependency may cause new installations to fail.
@hossam-adyen these problems were introduced by: #2476 @bramstroker will add the details |
Narrowed down the issue to be in https://github.com/Adyen/adyen-magento2/blob/develop/Setup/Recurring.php During execution of the recurring schema the following components will be constructed by DI container:
Construction of Customer resource calls
The eav entity types are created by data patch in The question is why this is in recurring schema in the first place as it has nothing to do with DB schema. It just sets some config settings. So the solution seems to me to execute this logic in a data patch, which ultimately also has a dependency on the Magento data patch which creates the |
Hi @pmzandbergen, thanks for your valuable contribution and dedicate time for opening this draft and providing this fix, please let us know when it's ready for review. If you also don't mine, please update the unit test file to avoid the failure of the PR checks |
Have a look at: #2509 (comment) |
I have changed current Workflow for CI/CD testing pipeline in our projects is as follows:
This fails without the fixes provided in this PR. It would be nice if similar procedure also can be verified in you QA pipeline, as it's not the first time our CI/CD pipelines break after (minor) upgrade of Adyen module. |
Can this be merged please so it can be part of upcoming release? |
Missing dependency may cause new installations to fail.
See: #1431 (comment)
Fixes: