[ECP-9064] Make asynchronous POS flow configurable #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 25, 2024 15:54
This was referenced Apr 2, 2024
Merged
RokPopov
approved these changes
Apr 5, 2024
|
khushboo-singhvi
approved these changes
Apr 8, 2024
RokPopov
added a commit
that referenced
this pull request
Apr 18, 2024
* [ECP-8912] Make Pos payments flow async (#2498) * ECP-8912/Make-POS-payments-flow-async * refactor * Make POS async * pos async * pos async * fix TypeError: Magento\Payment\Gateway\Data\PaymentDataObject::__construct(): Argument #1 ($order) must be of type Magento\Payment\Gateway\Data\OrderAdapterInterface, Magento\Sales\Model\Order\Interceptor given, called in /var/www/html/vendor/adyen/module-payment/Model/Api/AdyenPosCloud.php on line 54 and defined in /var/www/html/app/code/Magento/Payment/Gateway/Data/PaymentDataObject.php:26 * tuning backend of async * fix FE call * fixes * clean up * Refactor SubmitQuoteObserver * Refactor adyen-pos-cloud-method.js * put the correct status * Add test coverage for AdyenPosCloud & GuestAdyenPosCloud * Add test coverage for PaymentPosCloudHandlerTest * Add test coverage for SetOrderStateAfterPaymentObserverTest * Comments refactor * rename handleFaildResponse to handleFailedResponse * Terminal API does not return Authorised result code. * Update Plugin/GuestPaymentInformationResetOrderId.php * Update Plugin/PaymentInformationResetOrderId.php * Update events.xml --------- Co-authored-by: Peter Ojo <[email protected]> Co-authored-by: Can Demiralp <[email protected]> * [ECP-9064] Make asynchronous POS flow configurable (#2566) * [ECP-9064] Define new configuration field and getter for payment action * [ECP-9064] Pass payment_action config to frontend * [ECP-9064] Use POS payment action value on frontend and observers logic * [ECP-9064] Use constant definition for payment action field * [ECP-9064] Fix unit tests * [ECP-9064] Fix unit tests * [ECP-9064] Formatting * [ECP-9064] Update unit tests --------- Co-authored-by: Can Demiralp <[email protected]> * Update the tooltip and the label of the configuration field * Update unit tests --------- Co-authored-by: hossam-adyen <[email protected]> Co-authored-by: Peter Ojo <[email protected]> Co-authored-by: Can Demiralp <[email protected]> Co-authored-by: Rok Popov Ledinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new asynchronous POS cloud payment flow contains some breaking changes for the merchants who have already implement POS payments into their V9 stores. This PR introduces configuration
Order Creation Timefield forIn-person paymentsto make POS flow synchronous/asynchronous. This field has two potential values where havingBefore paymentby default.Before payment: Order will be created first then payment will be initiated. (More robust, allows asynchronous webhook to finalise the order in case of network degradation)After payment: Payment will be completed first then order will be created. (Fragile in case of network degradation, payment might be lost)Tested scenarios