Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9259] - Update payment method validation so updating billing information get's processed correctly. #2677

Merged
merged 10 commits into from
Aug 7, 2024
Merged

[ECP-9259] - Update payment method validation so updating billing information get's processed correctly. #2677

merged 10 commits into from
Aug 7, 2024

Conversation

raoulritter
Copy link
Member

@raoulritter raoulritter commented Jul 10, 2024 •
edited
Loading

Description

This PR refactors and improves the payment method validation for Adyen Checkout in order to simplify and the validation for 'base' payment methods without additional configuration.

Tested scenarios

  1. Attempted to place orders with empty data for SEPA payments (validation failed as expected).
  2. Tested redirect payment methods to ensure they pass validation without component data.
  3. Verified correct validation behavior for other payment methods with and without form data.
  4. Checked that the "Place Order" button remains clickable after a validation failure / updating address, allowing users to correct input and retry.
  5. Ensured that validation prevents redirection to the shipping page when form data is invalid or empty.

Fixes

@raoulritter raoulritter requested a review from a team as a code owner July 10, 2024 10:27
@raoulritter raoulritter changed the title [ECP-9259] - Update payment method validation so updating billing information get's processed correclty. [ECP-9259] - Update payment method validation so updating billing information get's processed correctly. Jul 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@raoulritter raoulritter merged commit 0cbc130 into main Aug 7, 2024
13 of 14 checks passed
@raoulritter raoulritter deleted the ECP-9259 branch August 7, 2024 13:25
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Merged
@peterojo peterojo added the Fix Indicates a bug fix label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterojo peterojo peterojo approved these changes

@RokPopov RokPopov RokPopov approved these changes

@candemiralp candemiralp Awaiting requested review from candemiralp

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raoulritter @peterojo @candemiralp @RokPopov