Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad StoreLocale resolver #2743

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Fix bad StoreLocale resolver #2743

merged 5 commits into from
Sep 27, 2024

Conversation

dimitriBouteille
Copy link
Contributor

@dimitriBouteille dimitriBouteille commented Sep 11, 2024 •
edited
Loading

This PR fix :

Capture d’écran du 2024-09-11 14-38-54

Capture d’écran du 2024-09-11 14-39-51

Original PR: #2706

Fixes #2750

@dimitriBouteille dimitriBouteille requested a review from a team as a code owner September 11, 2024 12:52
@dimitriBouteille
Copy link
Contributor Author

Hi Adyen team,

Why not implement code quality tools in addition to testing? Like phpstan or rector who are able to see these errors.

@dimitriBouteille dimitriBouteille mentioned this pull request Sep 20, 2024
Closed
@candemiralp
Copy link
Member

Hello @dimitriBouteille,

Thank you for your contribution and fixing this issue. Besides, we will introduce phpstan soon to prevent these issues in the feature.

Best Regards,
Can

@candemiralp candemiralp merged commit 4d2c099 into Adyen:main Sep 27, 2024
8 of 15 checks passed
@dimitriBouteille dimitriBouteille deleted the fix-bad-storelocal-resolver branch September 27, 2024 21:18
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushboo-singhvi khushboo-singhvi khushboo-singhvi approved these changes

@candemiralp candemiralp candemiralp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated Functionality: Creation of dynamic property $adyenHelper is deprecated
4 participants
@dimitriBouteille @candemiralp @khushboo-singhvi @peterojo