-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECP-9352] Implement onError handler on Amazon Pay component #2768
Open
candemiralp
wants to merge
6
commits into
main
Choose a base branch
from
ECP-9352
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candemiralp
had a problem deploying
to
internal
October 11, 2024 13:42
— with
GitHub Actions
Failure
candemiralp
had a problem deploying
to
internal
October 15, 2024 15:23
— with
GitHub Actions
Failure
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an Amazon Pay payment is declined on Amazon Pay hosted page and Amazon Pay payment component can't handle the decline flow, there is no way to proceed further on the checkout. Besides this issue, payment cancellation on Amazon Pay hosted page triggers a payment attempt on the plugin since the return URL contains
amazonCheckoutSessionId
, which always fails.This PR introduces a fix to these two issues.
As a solution to the first issue related to decline flow handling, we've implemented
onError
callback to handle cases wherehandledDeclineFlow()
function returns an error. In this case, plugin removesamazonCheckoutSessionId
parameter from the query parameters of the URL and remounts the Amazon Pay payment component. This allows shoppers to pay with Amazon Pay again. On the other hand, if decline flow is available for the given Amazon Pay session, the shopper will be redirected to Amazon Pay hosted payment page to update the payment method.To tackle the second issue related to payment cancellation on hosted payment page,
cancelUrl
parameter has been added. Now, shoppers are being redirected to the cart page instead of checkout if the payment is cancelled.Tested scenarios