-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECP-9482] Refactor HeaderDataBuilder and TransactionClient #2769
Open
SushmitaThakur
wants to merge
13
commits into
main
Choose a base branch
from
ECP-9482
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Builder class, Refactor all the usage of HeaderDataBuilder, Remover header builder from helper class and all its usage, Define header constants, Update dependency injection with new builder name, Synchronise the value of `frontendtype` to `luma` in relevant js files
SushmitaThakur
had a problem deploying
to
internal
October 8, 2024 19:48
— with
GitHub Actions
Error
SushmitaThakur
had a problem deploying
to
internal
October 8, 2024 19:48
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 8, 2024 19:48
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 8, 2024 19:48
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 8, 2024 19:48
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 8, 2024 19:48
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 8, 2024 19:48
— with
GitHub Actions
Failure
peterojo
reviewed
Oct 8, 2024
Gateway/Request/Header/ExternalPlatformHeaderDataBuilderInterface.php
Outdated
Show resolved
Hide resolved
peterojo
reviewed
Oct 8, 2024
Gateway/Request/Header/ExternalPlatformHeaderDataBuilderInterface.php
Outdated
Show resolved
Hide resolved
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:29
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 9, 2024 09:29
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:29
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:29
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:29
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:29
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:29
— with
GitHub Actions
Error
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:35
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:35
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:35
— with
GitHub Actions
Error
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:35
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 9, 2024 09:35
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:35
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 9, 2024 09:35
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 14, 2024 16:57
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 14, 2024 16:57
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 14, 2024 16:57
— with
GitHub Actions
Inactive
SushmitaThakur
temporarily deployed
to
internal
October 14, 2024 16:57
— with
GitHub Actions
Inactive
SushmitaThakur
temporarily deployed
to
internal
October 14, 2024 16:57
— with
GitHub Actions
Inactive
SushmitaThakur
temporarily deployed
to
internal
October 14, 2024 16:57
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 14, 2024 16:57
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 14, 2024 17:34
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 15, 2024 12:57
— with
GitHub Actions
Failure
…ts and tests, update header data builder tests, remove defaulting frontend type to headless
SushmitaThakur
had a problem deploying
to
internal
October 15, 2024 13:00
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 15, 2024 13:00
— with
GitHub Actions
Inactive
SushmitaThakur
temporarily deployed
to
internal
October 15, 2024 13:00
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 15, 2024 13:00
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 15, 2024 13:00
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 15, 2024 13:00
— with
GitHub Actions
Failure
SushmitaThakur
had a problem deploying
to
internal
October 15, 2024 13:00
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 15, 2024 13:10
— with
GitHub Actions
Inactive
SushmitaThakur
temporarily deployed
to
internal
October 15, 2024 13:10
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 15, 2024 13:10
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 15, 2024 13:10
— with
GitHub Actions
Inactive
SushmitaThakur
had a problem deploying
to
internal
October 15, 2024 13:10
— with
GitHub Actions
Failure
SushmitaThakur
temporarily deployed
to
internal
October 15, 2024 13:10
— with
GitHub Actions
Inactive
SushmitaThakur
temporarily deployed
to
internal
October 15, 2024 13:10
— with
GitHub Actions
Inactive
Quality Gate passedIssues Measures |
SushmitaThakur
changed the title
[ECP-9482] Refactor header data builder
[ECP-9482] Refactor HeaderDataBuilder
Oct 15, 2024
SushmitaThakur
changed the title
[ECP-9482] Refactor HeaderDataBuilder
[ECP-9482] Refactor HeaderDataBuilder and TransactionClient
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR -
HeaderDatabuilder
and movesbuildHeaderData
method fromData
helper class to the builder.HeaderDataBuiderInterface
that declares all the header constants.BaseTransaction
client class that accommodates common methods used by all transactions clientsTransactionClients
andPaymentDetails
class accordinglyTransactionClients
andPaymentDetails
di.xml
frontendType
constantfrontendType
value toluma
in JS renderersTested Scenarios