[ECP-9599]Implement the tracking of Headless requests to the FrontEndType header #2897
+69
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
amihajlovski
previously approved these changes
Feb 26, 2025
candemiralp
reviewed
Feb 26, 2025
| if (str_contains($requestUri, '/graphql')) { | ||
| $frontendType = 'headless-graphql'; | ||
| } else { | ||
| $frontendType = 'headless-rest'; |
There was a problem hiding this comment.
Express payments will fall under headless-rest category unless we indicate the frontendType in additional_data of place order functions of express method renderers. This might require some data clean-up to remove express payments from headless-rest payments. However, it would become cumbersome after having a huge data set. We can merge this as it is but until fixing it on express payment module, we will get some dirty data. Could you please check this with product?
candemiralp
reviewed
Feb 26, 2025
Helper/Data.php
Outdated
| if (is_null($frontendType)) { | ||
| // Check the request URI | ||
| $requestUri = $this->request->getPathInfo(); | ||
| if (str_contains($requestUri, '/graphql')) { |
There was a problem hiding this comment.
This logical comparison might create false-positives. Let's discuss it separately.
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
|
khushboo-singhvi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims tracking the Headless Frontend type requests, If it is Graphql requests, the
EXTERNAL_PLATFORM_FRONTEND_TYPEwill be set asheadless-graphqland falling back to REST Headless for all other remaining scenarios with the value set asheadless-restTested scenarios
Fixes