Skip to content

Commit

Permalink
Merge pull request #130 from Aeliot-Tm/todo-registrar-MTA2OTcx
Browse files Browse the repository at this point in the history
[TODO Registrar] automated registering of new TODOs
  • Loading branch information
Aeliot-Tm authored Oct 2, 2024
2 parents c0ff5ac + 23b9806 commit 4374e16
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/Service/InlineConfig/ArrayFromJsonLikeLexerBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private function addValue(CollectionInterface $collection, ?string $key, mixed $
}

/**
* TODO: move it into JsonLikeLexer.
* TODO: #126 move it into JsonLikeLexer.
*/
private function checkPredecessorType(int $current, ?int $predecessor): void
{
Expand Down
2 changes: 1 addition & 1 deletion src/Service/InlineConfig/InlineConfigFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
final class InlineConfigFactory implements InlineConfigFactoryInterface
{
/**
* TODO: create config specific for configured registrar.
* TODO: #125 create config specific for configured registrar.
*/
public function getInlineConfig(array $input): InlineConfigInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Service/Registrar/Github/LabelApiClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use Github\Api\Issue\Labels as LabelsApi;

/**
* TODO: cache list of labels
* TODO: #128 cache list of labels
* It reduce API-calls and speed up processing of issues with labels.
*/
final class LabelApiClient
Expand Down
2 changes: 1 addition & 1 deletion src/Service/Registrar/JIRA/IssueConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ protected function normalizeConfig(array $config): array
$config['components'] = (array) $config['components'];

if (\array_key_exists('type', $config)) {
// TODO: throw exception when exists key "issueType"
// TODO: #127 throw exception when exists key "issueType"
$config['issueType'] = $config['type'];
unset($config['type']);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/Registrar/RegistrarFactoryRegistry.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function getFactory(RegistrarType $type): RegistrarFactoryInterface
return match ($type) {
RegistrarType::Github => new GithubRegistrarFactory(),
RegistrarType::JIRA => new JiraRegistrarFactory(),
// TODO add factory of different registrars
// TODO #129 add factory of different registrars
default => throw new \DomainException(\sprintf('Not supported registrar type "%s"', $type->value)),
};
}
Expand Down

0 comments on commit 4374e16

Please sign in to comment.