Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON field match #2498

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

mmabrouk
Copy link
Member

Closes: AGE-1537
Closes: #2497

Description

The issue was that the setting values were not 1) propagated to the evaluation function when the call came from the backend 2) the json_field was not used to extract the field from the json. This PR fixes both issues

QA:

The following has been tested:

  • Regression: removing the settings from the input and making sure the new sanity checks work and propagate to the backend
  • The evaluator work when run from the backend in case of True (field exists and it is the same as correct_asnwer)
  • Works, in case the llm output is not json
  • Works, in case the llm output does not contain the field
  • Works in case the llm output contains the field but the result is not different

What is still to be QA'ed:

  • Does the interface work from the UI test interface in cloud

propagated the settings which include the field and use them in the evaluator

Closes: AGE-1537
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 11:05am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 11:05am

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 20, 2025
@dosubot dosubot bot added Backend bug Something isn't working labels Feb 20, 2025
Copy link
Contributor

@jp-agenta jp-agenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jp-agenta jp-agenta changed the base branch from main to release/v0.33.7 February 20, 2025 17:09
@jp-agenta jp-agenta merged commit 202c0c1 into release/v0.33.7 Feb 20, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AGE-1537] json_field_match not working as expected
2 participants